Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace double-dash with m-dash #14225

Merged
merged 8 commits into from
Jul 22, 2023
Merged

Replace double-dash with m-dash #14225

merged 8 commits into from
Jul 22, 2023

Conversation

queengooborg
Copy link
Collaborator

This PR replaces all instances of a double-dash (--) with an m-dash (—) throughout translated content. This synchronizes formatting with upstream.

@queengooborg queengooborg requested review from a team as code owners July 14, 2023 17:02
@queengooborg queengooborg requested review from JuanVqz, myshov, yechoi42, kenji-yamasaki, SphinxKnight, yin1999 and josielrocha and removed request for a team July 14, 2023 17:02
@github-actions github-actions bot added l10n-ja Issues related to Japanese content. l10n-fr Issues related to French content. l10n-zh Issues related to Chinese content. l10n-es Issues related to Spanish content. l10n-ru Issues related to Russian content. l10n-ko Issues related to Korean content. l10n-pt-br Issues related to Brazilian Portuguese system Infrastructure and configuration for the project labels Jul 14, 2023
@queengooborg
Copy link
Collaborator Author

Thanks for the review, @yin1999! Since there's additional grammatical changes being made here, I've decided to split the Chinese changes into its own PR so it can be reviewed and merged independently (and probably quicker)!

@github-actions github-actions bot removed the l10n-zh Issues related to Chinese content. label Jul 15, 2023
@yin1999 yin1999 mentioned this pull request Jul 15, 2023
Merged
sashasushko
sashasushko approved these changes Jul 15, 2023
View reviewed changes
Copy link
Member

@sashasushko sashasushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve for ru. Thanks 🤝

@sashasushko sashasushko removed the request for review from myshov July 15, 2023 10:10
cw118
cw118 approved these changes Jul 16, 2023
View reviewed changes
Copy link
Member

@cw118 cw118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for l10n-fr, thanks very much!

@cw118 cw118 removed the request for review from SphinxKnight July 16, 2023 20:38
mfuji09
mfuji09 approved these changes Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@mfuji09 mfuji09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for ja.

@queengooborg queengooborg removed the request for review from kenji-yamasaki July 18, 2023 14:46
josielrocha
josielrocha approved these changes Jul 19, 2023
View reviewed changes
Copy link
Collaborator

@josielrocha josielrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for pt-BR

@github-actions github-actions bot added the merge conflicts 🚧 This pull request has merge conflicts that must be resolved. label Jul 19, 2023
@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 This pull request has merge conflicts that must be resolved. label Jul 19, 2023
@queengooborg
Copy link
Collaborator Author

Thanks for everyone's review, we're just waiting on @mdn/yari-content-ko's review now and then this can be merged!

@github-actions github-actions bot added the merge conflicts 🚧 This pull request has merge conflicts that must be resolved. label Jul 20, 2023
@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 This pull request has merge conflicts that must be resolved. label Jul 20, 2023
@queengooborg
Copy link
Collaborator Author

Still haven't heard back from the Korean team -- I'm going to assume that this is alright for Korean, and if it isn't, we can revert it for Korean pages later!

@queengooborg queengooborg merged commit c5f9c93 into main Jul 22, 2023
10 checks passed
@queengooborg queengooborg deleted the lint/m-dash branch July 22, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yin1999 yin1999 yin1999 left review comments

@josielrocha josielrocha josielrocha approved these changes

@sashasushko sashasushko sashasushko approved these changes

@mfuji09 mfuji09 mfuji09 approved these changes

@Graywolf9 Graywolf9 Graywolf9 approved these changes

@cw118 cw118 cw118 approved these changes

@yechoi42 yechoi42 Awaiting requested review from yechoi42 yechoi42 is a code owner automatically assigned from mdn/yari-content-ko

Assignees
No one assigned
Labels
l10n-es Issues related to Spanish content. l10n-fr Issues related to French content. l10n-ja Issues related to Japanese content. l10n-ko Issues related to Korean content. l10n-pt-br Issues related to Brazilian Portuguese l10n-ru Issues related to Russian content. system Infrastructure and configuration for the project
Projects
l10n-fr
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@queengooborg @josielrocha @sashasushko @mfuji09 @Graywolf9 @yin1999 @cw118